From 8389af6c6e792cd7b7ee083c1b8952b21866cee4 Mon Sep 17 00:00:00 2001
From: Romain J <romain.ordi@gmail.com>
Date: Sat, 16 May 2020 14:12:46 +0200
Subject: [PATCH] perf(storage): move theme choice to localstorage

---
 apps/gnous_eu/templates/layouts/foot.html | 14 +++++++-------
 locale/en/LC_MESSAGES/django.po           |  2 +-
 locale/fr/LC_MESSAGES/django.po           |  2 +-
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/apps/gnous_eu/templates/layouts/foot.html b/apps/gnous_eu/templates/layouts/foot.html
index 1d2d3de..e535402 100644
--- a/apps/gnous_eu/templates/layouts/foot.html
+++ b/apps/gnous_eu/templates/layouts/foot.html
@@ -25,7 +25,7 @@ Don't judge me
             }
         })
 
-        document.cookie = `theme=${theme}`
+        window.sessionStorage.setItem('theme', theme)
     }
 
     theme.addEventListener('change', function () {
@@ -34,8 +34,8 @@ Don't judge me
 </script>
 
 <script>
-    let cookies = document.cookie.split('; ');
-    let banner_cookie = document.cookie.split('; ').filter(e => e.startsWith('cookie-banner='))[0];
+    cookies = document.cookie.split('; ');
+    banner_cookie = document.cookie.split('; ').filter(e => e.startsWith('cookie-banner='))[0];
 
     if (banner_cookie === undefined || banner_cookie.split('cookie-banner=')[1] !== 'hidden') {
         cookie_notification = UIkit.notification(
@@ -51,9 +51,9 @@ Don't judge me
 </script>
 
 <script>
-    let theme_cookie = document.cookie.split('; ').filter(e => e.startsWith('theme='))[0];
-    if (theme_cookie !== undefined) {
-        applyTheme(theme_cookie.split('theme=')[1]);
-        window.theme.checked = theme_cookie.split('theme=')[1] === 'dark'
+    theme_session = window.sessionStorage.getItem('theme')
+    if (theme_session !== null) {
+        applyTheme(theme_session);
+        window.theme.checked = theme_session === 'dark'
     }
 </script>
\ No newline at end of file
diff --git a/locale/en/LC_MESSAGES/django.po b/locale/en/LC_MESSAGES/django.po
index b8cf1ce..1ef2ff4 100644
--- a/locale/en/LC_MESSAGES/django.po
+++ b/locale/en/LC_MESSAGES/django.po
@@ -175,5 +175,5 @@ msgstr "Let's discuss your proposal in more detail! We are open to any partnersh
 
 #: apps/gnous_eu/templates/layouts/foot.html:42
 msgid "Bla bla bla... bannière alakon pour dire qu&amp;on utilise des cookies (pour la langue et cette bannière)"
-msgstr "GnousEU uses cookies in order to save the language of the site you are using, its theme and the closing of this banner."
+msgstr "GnousEU uses cookies in order to save the language of the site you are using and the closing of this banner."
 
diff --git a/locale/fr/LC_MESSAGES/django.po b/locale/fr/LC_MESSAGES/django.po
index 74f083e..4deece2 100644
--- a/locale/fr/LC_MESSAGES/django.po
+++ b/locale/fr/LC_MESSAGES/django.po
@@ -167,4 +167,4 @@ msgstr ""
 
 #: apps/gnous_eu/templates/layouts/foot.html:42
 msgid "Bla bla bla... bannière alakon pour dire qu&amp;on utilise des cookies (pour la langue et cette bannière)"
-msgstr "GnousEU utilise des cookies afin de sauvegarder la langue du site que vous utilisez, son theme ainsi que pour la fermeture de cette bannière."
+msgstr "GnousEU utilise des cookies afin de sauvegarder la langue du site que vous utilisez ainsi que pour la fermeture de cette bannière."